fix: reload iframe plugins when filters causing errors are changed/removed #2675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The verify workflow should run on tags, so that a corresponding branch is created in the d2-ci repository Do not run the release step on PRs, but do allow it for pushes yarn cypress install sometimes fails. Turns out it isn't necessary anyway since the cypress-io gh action takes care of installing cypress.
Automatically merged.
Automatically merged.
Bumps [json5](https://github.com/json5/json5) from 1.0.1 to 1.0.2. - [Release notes](https://github.com/json5/json5/releases) - [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md) - [Commits](json5/json5@v1.0.1...v1.0.2) --- updated-dependencies: - dependency-name: json5 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jen Jones Arnesen <[email protected]>
* chore: nightly failing to set up cypress (#2378) The verify workflow should run on tags, so that a corresponding branch is created in the d2-ci repository Do not run the release step on PRs, but do allow it for pushes yarn cypress install sometimes fails. Turns out it isn't necessary anyway since the cypress-io gh action takes care of installing cypress. * fix(translations): sync translations from transifex (dev) Automatically merged. * docs: move docs to app (#2384) * chore(release): cut 100.0.1 [skip release] ## [100.0.1](v100.0.0...v100.0.1) (2023-06-12) ### Bug Fixes * **translations:** sync translations from transifex (dev) ([5b0b3b6](5b0b3b6)) * chore(deps): bump @dhis2/analytics from 25.1.10 to 25.1.15 Bumps [@dhis2/analytics](https://github.com/dhis2/analytics) from 25.1.10 to 25.1.15. - [Release notes](https://github.com/dhis2/analytics/releases) - [Changelog](https://github.com/dhis2/analytics/blob/master/CHANGELOG.md) - [Commits](dhis2/analytics@v25.1.10...v25.1.15) --- updated-dependencies: - dependency-name: "@dhis2/analytics" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Jen Jones Arnesen <[email protected]> Co-authored-by: @dhis2-bot <[email protected]> Co-authored-by: Jan Henrik Øverland <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Automatically merged.
Automatically merged.
Also increase the EXTENDED_TIMEOUT
* chore: nightly failing to set up cypress (#2378) The verify workflow should run on tags, so that a corresponding branch is created in the d2-ci repository Do not run the release step on PRs, but do allow it for pushes yarn cypress install sometimes fails. Turns out it isn't necessary anyway since the cypress-io gh action takes care of installing cypress. * fix(translations): sync translations from transifex (dev) Automatically merged. * docs: move docs to app (#2384) * chore(release): cut 100.0.1 [skip release] ## [100.0.1](v100.0.0...v100.0.1) (2023-06-12) ### Bug Fixes * **translations:** sync translations from transifex (dev) ([5b0b3b6](5b0b3b6)) * chore(deps): bump @dhis2/ui from 8.13.6 to 8.13.11 Bumps [@dhis2/ui](https://github.com/dhis2/ui/tree/HEAD/collections/ui) from 8.13.6 to 8.13.11. - [Release notes](https://github.com/dhis2/ui/releases) - [Changelog](https://github.com/dhis2/ui/blob/master/CHANGELOG.md) - [Commits](https://github.com/dhis2/ui/commits/v8.13.11/collections/ui) --- updated-dependencies: - dependency-name: "@dhis2/ui" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Jen Jones Arnesen <[email protected]> Co-authored-by: @dhis2-bot <[email protected]> Co-authored-by: Jan Henrik Øverland <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This is temporary during summer 2023 when there is very little frontend or backend activity
|
🚀 Deployed on https://pr-2675.dashboard.netlify.dhis2.org |
jenniferarnesen
force-pushed
the
dev
branch
from
e63aff9 to
35877e1
Compare
jenniferarnesen
force-pushed
the
dev
branch
2 times, most recently
from
b919316 to
7f603d6
Compare
|
|
Closing.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements DHIS2-18576
Key features
Description
Sometimes when applying certain filters some iframe plugin can show an error, for example if no analytics data is returned.
When this happens, an error screen is shown in place of the iframe tag.
When removing the filter, the error screen was still shown and the iframe plugin was not reloaded.
The PR addresses 2 issues.
filterVersionwhich controls the clearing of the error in theIframePlugincomponent was never changing, thus not clearing the error when filters were changed/removed.getPropslistener was not initialised when the iframe tag was added again, causing the plugin to fail to load.TODO
Known issues
IframePluginre-render more than needed and Cypress runs the tests after the first re-render which still has the "outdated" UI.Screenshots
Filter causing an error:
Before, removing the filter did not reload the iframe plugin:
After, removing the filter correctly reloads the iframe plugin:
